Changed route related to money request #40576

shubham1206agra · 2024-04-19T15:06:33Z

Details

Fixed Issues

$ #40073
$ #40615

Tests

Split expense flow

Manual

Press the global create menu.
Press on Split expense.
Manual > Enter amount > Next.
Confirm there is no Next button present when no participants are selected.
Select any number of participants.
Verify that you can select more than 1 user.
Press Next.
Verify that the confirmation page looks as expected.

Scan

Press the global create menu.
Press on Split expense.
Scan > Add receipt.
Confirm there is no Next button present when no participants are selected.
Select any number of participants.
Verify that you can select more than 1 user.
Press Next.
Verify that the confirmation page looks as expected.

Submit expense flow

Manual

Press the global create menu.
Press on Submit expense.
Manual > Enter amount > Next.
Confirm there is no Next button present.
Press on any participant.
Verify that you’ll be navigated to the confirmation page directly.

Scan

Press the global create menu.
Press on Submit expense.
Scan > Add receipt.
Confirm there is no Next button present.
Press on any participant.
Verify that you’ll be navigated to the confirmation page directly.

Deeplinking Test

Submit expense flow

Press the global create menu.
Press on Submit expense.
Change submit to request in the url. (Verify that you are able to see the same page with no change).
Enter the amount > Next.
Observe that the request changed into submit.
Now, again try to do step 3, but now you will be shown Not Found Page.
Repeat the step 3 with above results on the confirmation page.

Pay someone flow

Press the global create menu.
Press on Pay someone.
Change pay to send in the url. (Verify that you are able to see the same page with no change).
Enter the amount > Next.
Observe that the send changed into pay.
Now, again try to do step 3, but now you will be shown Not Found Page.
Repeat the step 3 with above results on the confirmation page.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-04-21.at.10.20.15.PM.mov

iOS: Native

Screen.Recording.2024-04-21.at.10.28.51.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-21.at.10.15.30.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-21.at.10.12.13.PM.mov

MacOS: Desktop

Screen.Recording.2024-04-21.at.10.25.29.PM.mov

melvin-bot · 2024-04-19T15:53:42Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2024-04-21T12:07:17Z

BUG?: not found page appears when trying to access participants page with request url

Press +
Submit expense > Scan
Attach a file
Change submit in the url to request > Enter

Screen.Recording.2024-04-21.at.2.56.45.in.the.afternoon.mov

shubham1206agra · 2024-04-21T12:19:21Z

@getusha Intended behavior. See tests section.

getusha · 2024-04-21T16:08:47Z

BUG: not able to select a participant

Press the global +
Split expense
Enter amount > Next
Try to select a participant

Screen.Recording.2024-04-21.at.6.59.49.in.the.evening.mov

getusha · 2024-04-21T17:30:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-22.at.1.01.51.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-04-22.at.12.39.20.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-04-22.at.1.21.57.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-04-22.at.12.22.03.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-22.at.11.28.44.in.the.morning.1.mov

MacOS: Desktop

Screen.Recording.2024-04-22.at.12.52.13.in.the.afternoon.mov

getusha · 2024-04-21T17:52:41Z

@shubham1206agra Pressing the back button from Pay someone page is not closing the page after opening it from a deeplink. not able to reproduce on prod release.

npx uri-scheme open new-expensify://create/pay/start/1/74734608533517 --android

Screen.Recording.2024-04-21.at.8.29.22.in.the.evening.mov

getusha · 2024-04-21T18:06:55Z

@mountiny can we trigger an adhoc build for this? 🙇

mountiny · 2024-04-21T21:28:12Z

Running it here https://github.com/Expensify/App/actions/runs/8775630750

github-actions · 2024-04-21T21:59:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40576/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40576/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/40576/NewExpensify.dmg	https://40576.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shubham1206agra · 2024-04-22T03:36:29Z

@shubham1206agra Pressing the back button from Pay someone page is not closing the page after opening it from a deeplink. not able to reproduce on prod release.

npx uri-scheme open new-expensify://create/pay/start/1/74734608533517 --android

Screen.Recording.2024-04-21.at.8.29.22.in.the.evening.mov

Able to repro on ios in main branch. So checking it off for now.

shubham1206agra · 2024-04-22T03:36:56Z

BUG: not able to select a participant

Press the global +

Split expense

Enter amount > Next

Try to select a participant

Screen.Recording.2024-04-21.at.6.59.49.in.the.evening.mov

Not able to repro at all.

getusha

looks good, a couple of minor comments.

src/libs/Navigation/Navigation.ts

src/libs/ReportUtils.ts

Co-authored-by: G T <75031127+getusha@users.noreply.github.com>

getusha

LGTM, tests well.

mountiny

One comment

src/libs/IOUUtils.ts

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>

mountiny

Thanks!

OSBotify · 2024-04-23T23:44:28Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra added 2 commits April 19, 2024 20:36

Changed route related to money request

ad215c4

Protected some routes against problems

b29bad7

mountiny assigned shubham1206agra Apr 19, 2024

mountiny requested a review from getusha April 19, 2024 15:37

shubham1206agra marked this pull request as ready for review April 19, 2024 15:53

shubham1206agra requested a review from a team as a code owner April 19, 2024 15:53

melvin-bot bot requested review from mountiny and removed request for a team April 19, 2024 15:53

Renaming some consts and minor updates to header title

1e0b314

shubham1206agra mentioned this pull request Apr 20, 2024

Update the header name in Track expense, Submit expense, and Split expense #40615

Closed

shubham1206agra and others added 2 commits April 20, 2024 06:34

Merge branch 'main' into edit-route

5be3d83

Fixing routes after merge

62ef4b8

Merge branch 'Expensify:main' into edit-route

d91f275

mountiny added the Ready To Build label Apr 21, 2024

Merge branch 'Expensify:main' into edit-route

22891eb

getusha reviewed Apr 22, 2024

View reviewed changes

src/libs/Navigation/Navigation.ts Outdated Show resolved Hide resolved

src/libs/ReportUtils.ts Show resolved Hide resolved

shubham1206agra commented Apr 22, 2024

View reviewed changes

src/libs/ReportUtils.ts Show resolved Hide resolved

shubham1206agra and others added 2 commits April 22, 2024 17:33

Apply suggestions from code review

bde1001

Apply suggestions from code review

3a7e416

Co-authored-by: G T <75031127+getusha@users.noreply.github.com>

getusha approved these changes Apr 22, 2024

View reviewed changes

mountiny previously approved these changes Apr 22, 2024

View reviewed changes

src/libs/IOUUtils.ts Outdated Show resolved Hide resolved

shubham1206agra dismissed mountiny’s stale review via 3fe5d82 April 22, 2024 12:39

Update src/libs/IOUUtils.ts

3fe5d82

Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>

mountiny approved these changes Apr 22, 2024

View reviewed changes

mountiny merged commit d084710 into Expensify:main Apr 22, 2024
16 checks passed

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

mountiny mentioned this pull request Apr 29, 2024

[$250] [HOLD for payment 2024-05-05] Payment issue for Add Split expense to Global Create #41255

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed route related to money request #40576

Changed route related to money request #40576

shubham1206agra commented Apr 19, 2024 •

edited

Loading

melvin-bot bot commented Apr 19, 2024

getusha commented Apr 21, 2024

shubham1206agra commented Apr 21, 2024

getusha commented Apr 21, 2024

getusha commented Apr 21, 2024 •

edited

Loading

getusha commented Apr 21, 2024 •

edited

Loading

getusha commented Apr 21, 2024

mountiny commented Apr 21, 2024

github-actions bot commented Apr 21, 2024

shubham1206agra commented Apr 22, 2024

shubham1206agra commented Apr 22, 2024

getusha left a comment

getusha left a comment

mountiny left a comment

mountiny left a comment

OSBotify commented Apr 23, 2024

Changed route related to money request #40576

Changed route related to money request #40576

Conversation

shubham1206agra commented Apr 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Split expense flow

Manual

Scan

Submit expense flow

Manual

Scan

Deeplinking Test

Submit expense flow

Pay someone flow

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 19, 2024

getusha commented Apr 21, 2024

shubham1206agra commented Apr 21, 2024

getusha commented Apr 21, 2024

getusha commented Apr 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha commented Apr 21, 2024 • edited Loading

getusha commented Apr 21, 2024

mountiny commented Apr 21, 2024

github-actions bot commented Apr 21, 2024

shubham1206agra commented Apr 22, 2024

shubham1206agra commented Apr 22, 2024

getusha left a comment

Choose a reason for hiding this comment

getusha left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 23, 2024

shubham1206agra commented Apr 19, 2024 •

edited

Loading

getusha commented Apr 21, 2024 •

edited

Loading

getusha commented Apr 21, 2024 •

edited

Loading